Support for 18n-ally VS Code extension

cibernox / svelte-intl-precompile

I18n library for Svelte.js that analyzes your keys at build time for max performance and minimal footprint

https://svelte-intl-precompile.com

ISC License

274 stars 13 forks source link

Support for 18n-ally VS Code extension #29

Closed mr-islam closed 2 years ago

mr-islam commented 2 years ago

Hi, thank you for your work :)

Maybe this is out of scope, but when working with anything i18n, the i18n-Ally extension makes work really fast and easy. It would be awesome to get support for this, like svelte-i18n already does

cibernox commented 2 years ago

It would indeed. I don't know what changes are required, I should investigate that. The API is almost identical so it shouldn't be hard

mr-islam commented 2 years ago

Oh my, thank you for your super fast response!

I was exploring to try get it working… after about an hour, the most simple thing got it working: manually selecting Svelte as the framework in the extension settings

"i18n-ally.enabledFrameworks": [ "svelte" ]

So presumably, it failed to auto-detect because either:

didn't find svelte-i18n syntax (not likely because it's pretty much the same, changing t for _)
doesn't support sveltekit seamlessly (in which case it's an issue for the extension / the template for this library)

If you could confirm this solution works for you, documenting it would be awesome

Thank you so much 🌹

RickMeijer commented 2 years ago

Just a random guy, but I can confirm adding svelte to the enabledFrameworks has my 18nally extension working as well.

cibernox commented 2 years ago

Thanks, I believe this can be closed now.

cibernox commented 2 years ago

For completeness, I've requested this library to be officially supported out of the box: https://github.com/lokalise/i18n-ally/issues/712

Hopefully it won't take too long.