cibernox / svelte-media

Svelte.js util to easily observe media queries as a reactive store
MIT License
58 stars 4 forks source link

svelte 4 compatibility #24

Open Bluebie opened 1 year ago

Bluebie commented 1 year ago

svelte-media gets in the way of updating to svelte 4:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: svelte-media@0.1.5
npm ERR! Found: svelte@4.0.0
npm ERR! node_modules/svelte
npm ERR!   peer svelte@"^3.54.0 || ^4.0.0-next.0" from @sveltejs/kit@1.20.4
npm ERR!   node_modules/@sveltejs/kit
npm ERR!     peer @sveltejs/kit@"^1.0.0" from @sveltejs/adapter-node@1.2.4
npm ERR!     node_modules/@sveltejs/adapter-node
npm ERR!       dev @sveltejs/adapter-node@"^1.2.4" from the root project
npm ERR!     peer @sveltejs/kit@"^1.5.0" from @sveltejs/adapter-static@2.0.2
npm ERR!     node_modules/@sveltejs/adapter-static
npm ERR!       dev @sveltejs/adapter-static@"^2.0.2" from the root project
npm ERR!     1 more (the root project)
npm ERR!   peer svelte@"^3.54.0 || ^4.0.0" from @sveltejs/vite-plugin-svelte@2.4.2
npm ERR!   node_modules/@sveltejs/vite-plugin-svelte
npm ERR!     @sveltejs/vite-plugin-svelte@"^2.4.1" from @sveltejs/kit@1.20.4
npm ERR!     node_modules/@sveltejs/kit
npm ERR!       peer @sveltejs/kit@"^1.0.0" from @sveltejs/adapter-node@1.2.4
npm ERR!       node_modules/@sveltejs/adapter-node
npm ERR!         dev @sveltejs/adapter-node@"^1.2.4" from the root project
npm ERR!       2 more (@sveltejs/adapter-static, the root project)
npm ERR!     peer @sveltejs/vite-plugin-svelte@"^2.2.0" from @sveltejs/vite-plugin-svelte-inspector@1.0.3
npm ERR!     node_modules/@sveltejs/vite-plugin-svelte-inspector
npm ERR!       @sveltejs/vite-plugin-svelte-inspector@"^1.0.3" from @sveltejs/vite-plugin-svelte@2.4.2
npm ERR!   5 more (@sveltejs/vite-plugin-svelte-inspector, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@"^3.14.1" from svelte-media@0.1.5
npm ERR! node_modules/svelte-media
npm ERR!   svelte-media@"^0.1.5" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: svelte@3.59.2
npm ERR! node_modules/svelte
npm ERR!   peer svelte@"^3.14.1" from svelte-media@0.1.5
npm ERR!   node_modules/svelte-media
npm ERR!     svelte-media@"^0.1.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution

package.json peerDependancies should be updated to accept 4.x

aakash14goplani commented 10 months ago

Any updates on this?

cbertram commented 1 month ago

As a workaround you can add an override to your own package.json:

    "overrides": {
        "svelte-media": {
            "svelte": "^4.0.0"
        }
    },