cibikle / LaSSI

LaSSI (the Last Starship Save Inspector) is a free, open source, cross-platform, fan-made tool for inspecting and editing save files for "The Last Starship" by Introversion Software (https://www.introversion.co.uk/introversion/). Cross-platform UI made possible by Eto (https://github.com/picoe/Eto)
GNU Affero General Public License v3.0
3 stars 3 forks source link

Tools enabled erroneously #142

Closed cibikle closed 1 week ago

cibikle commented 6 months ago

"MarkStrandedShipsDerelict", "ReassignMissions", "FireCrew", and "ClaimGhostShips" are enabled erroneously, including when no save file is loaded.

cibikle commented 1 week ago

MarkStrandedShipsDerelict shows erroneous "job done" message regardless of if there was anything to do (harmless but misleading) and is then marked as unavailable. Both ReassignMissions and FireCrew show empty dlogs for the user to pick a ship from (harmless but odd). ClaimGhostShips causes an exception. This, at least, must be fixed.

cibikle commented 1 week ago

Turns out I forgot how to set up new tools. Enabled has to be set to false manually on each tool (initial setup is not handled by the EnableTools()/CheckEnablablility() steps). I really need to overhaul this whole thing.

Also added some checks to the tools report empty resultsets better.