search

cibikle / LaSSI

LaSSI (the Last Starship Save Inspector) is a free, open source, cross-platform, fan-made tool for inspecting and editing save files for "The Last Starship" by Introversion Software (https://www.introversion.co.uk/introversion/). Cross-platform UI made possible by Eto (https://github.com/picoe/Eto)
GNU Affero General Public License v3.0
3 stars 3 forks source link

Linux build double-zip problem #143

Closed cibikle closed 5 months ago

cibikle commented 6 months ago

The Linux build workflow produces a zipped zip file. That's inconvenient. The upload step automatically zips the artifact and I'm not sure how to prevent that. Why not remove the step that zips the file before upload? Can't! Need that to protect the exec bit. I think.

Totengeist commented 5 months ago

I think you need to remove line 46 (zip LaSSI.zip LaSSI) and replace line 55 with:

        path: ${{ env.Wap_Project_Directory }}/output/LaSSI.zip

If you look at your Windows workflow, you're just giving actions/upload-artifact@v3 the whole output directory, whereas in the Linux workflow, you're giving it the ZIP file. It's taking the input you give it and zipping it. Since you're zipping either way, it should still save the exec bit.

I'm gonna fork the repo and test it. If that solves it, then I'll give you a PR, if you like.

EDIT: Nope, it looks like you're right. upload-artifact doesn't keep permissions. The official repo suggests tarring the file first.