search

cibikle / LaSSI

LaSSI (the Last Starship Save Inspector) is a free, open source, cross-platform, fan-made tool for inspecting and editing save files for "The Last Starship" by Introversion Software (https://www.introversion.co.uk/introversion/). Cross-platform UI made possible by Eto (https://github.com/picoe/Eto)
GNU Affero General Public License v3.0
3 stars 3 forks source link

Fix issues with Linux artifacts by moving to automated releases #145

Closed Totengeist closed 5 months ago

Totengeist commented 5 months ago

I thought about this a bit and am proposing a change to how I think you're doing releases. The problem with the Linux builds not keeping the +x bit is that the upload-artifact action doesn't support saving permissions. A solution that I think might work well is to move to using ncipollo/release-action instead.

What you would do when you're ready to publish a release is create a draft release with an associated tag for the version number (v0.2.9.3, for example). Once it's saved, you run your workflows and they will automatically upload the artifacts as release builds to that draft release. You can then review everything, set your title and description and make the release public.

This PR does that, so let me know your thoughts.

Totengeist commented 5 months ago

I've added the permissions config as requested.