search

cibotech / evilplot

A Scala combinator-based plotting library.
https://cibotech.github.io/evilplot
BSD 3-Clause "New" or "Revised" License
242 stars 25 forks source link

Make sure scalactic dependency doesn't leak to downstream projects #146

Closed williamyaoh closed 10 months ago

williamyaoh commented 10 months ago

It looks like for a while now, the scalactic dependency has been erroneously marked as needed for runtime, rather than just for tests. This causes the scalactic version specified here to leak to any code that depends on evilplot. Since scalatest is marked as test-only in the dependencies here, this can cause scalatest and scalactic versions to go out of sync in downstream code, causing confusing compile errors. It seems like this issue has gone unnoticed because up until evilplot 0.9.0, we were using a fairly old version of scalatest; when we updated scalatest to 3.2.15, now suddenly we're overriding downstream code with a newer version of scalactic.

(For CIBO folks, see this comment for some more context.)

williamyaoh commented 10 months ago

okay, the CI statuses seem to have ended up in a weird state, so i'm going to close and reopen this PR