Wrong usage of bool function

cibrandocampo / synology-transcoding

Transcoding optimizations for Synology Photo

MIT License

8 stars 0 forks source link

Wrong usage of bool function #12

Open goulou opened 5 months ago

goulou commented 5 months ago

bool(conf.get('FFmpeg', 'HW_TRANSCODING') always return True, as bool("False") == True. One should use the built-in function "getboolean" from configparser :

if conf.getboolean('FFmpeg', 'HW_TRANSCODING'):

Will try to make a PR.

goulou commented 5 months ago

line 116 and 33 of ffmpeg_commands.py