cicero-interactive / classic-youtube-design

Recreates the classic YouTube experience within the new polymer layout.
https://addons.mozilla.org/de/firefox/addon/classic-youtube-design/
GNU General Public License v3.0
12 stars 4 forks source link

Old(480p) size of player #2

Open Stepan-H opened 4 years ago

Stepan-H commented 4 years ago

In old design, player does smaller player, see attachement - pucture ... It's good, because browser load video in 480p when you have automatic resolution...

480p

NebelNidas commented 4 years ago

Ah, ok, now I understand it. :) This is because the old design had hardcoded widths for the page itself, so every few hundred pixels in width (when a certain height is matched), the page resizes itself to these forced values. The new layout is different: it is actually quite responsive, which in my opinion is the better method. However, you may have noticed that the player itself doesn't resize correctly with my add on, that's because the player width isn't actually responsive but is getting resized with JavaScript. This is bad because I changed the width proportions back to the old design, and now the video player often has white space to the bottom and right. I'm still looking for a fix, and might actually re-implement the old behavior.

NebelNidas commented 4 years ago

The above mentioned issue with the bars around the player is now fixed with 161d8256d42ed95e336cfd655acbe3a6f74b31bf. However, it's still the new responsive behavior, as the player width gets dictated by JavaScript. So I could fix the page at the 480p size, but the player itself would still get resized according to the actual underlying responsive layout. Maybe could get fixed in the future, but don't expect it anytime soon, as JavaScript debugging really is a pain in the ass... 😅