search

cicero-interactive / classic-youtube-design

Recreates the classic YouTube experience within the new polymer layout.
https://addons.mozilla.org/de/firefox/addon/classic-youtube-design/
GNU General Public License v3.0
12 stars 4 forks source link

List View for video channels #6

Open Nicholas-Steel opened 3 years ago

Nicholas-Steel commented 3 years ago

https://www.youtube.com/user/GameGrumps/videos https://www.youtube.com/user/JamesNintendoNerd/videos etc.

The old non-polymer design of Youtube let you display videos in a List view, Polymer only offers the Grid view. Is it feasible to implement the List View? Below is a comparison of List View and Grid View. (Also can anything be done regarding the white seams when using the Dark Theme?)

Youtube List View Youtube's grid view

NebelNidas commented 3 years ago

The list view should be relatively easy, as I would just have to get the thumbnail and description to display side by side and give it a 100% width. It won't look the same as in the old layout, but should be similar enough. I don't think I'll be able to do anything about the find feature, but I'll look into it.

Also can anything be done regarding the white seams when using the Dark Theme?

As stated in the ReadMe, dark mode isn't supported yet as the extension uses hard-coded overwrites. This is being changed in the currently ongoing refactoring, but as I'm mostly just one person and have very limited time, it unfortunately will be a while until this is finished 😕

Nicholas-Steel commented 3 years ago

I think what happens with the Find feature is that the page has the full name of the videos loaded, it just doesn't visibly display the full name. So if you enter a word in to the Find box that is in a video name but not visible, the browser will scroll the page to where the highlighted word is but you won't be able to see where on the page the highlighted word is since it's invisible.

If your idea gets the full name of the videos visible without mouse hovering over videos than that should fix that.

NebelNidas commented 3 years ago

I've managed it to work like this: image

Would this be OK, or do you have ideas for improvements?

Edit: Also, I think the search issue is gone, it was exactly like you described it above 😉

Nicholas-Steel commented 3 years ago

Yes, that looks very awesome.

Nicholas-Steel commented 3 years ago

I'm running v0.2.0 and this... doesn't seem to have been implemented? I'm not sure what the fixed:v0.2 tag is supposed to imply on your github.

NebelNidas commented 3 years ago

Oops, you're right, I postponed the feature to 0.3 and forgot to adjust the tag 😅

Nicholas-Steel commented 3 years ago

In case anyone else is after this feature, Youtube Redux has just now added support for List View: https://old.reddit.com/r/youtube/comments/jvg4mf/youtube_redux_an_extension_i_made_that_scales/

image