search

ciceroOslo / ciceroscm

Python version of the CICERO-SCM simple climate model/emulator
Apache License 2.0
17 stars 4 forks source link

Definition of lifetime parameters without needing to call an internal function. #112

Open benmsanderson opened 1 year ago

benmsanderson commented 1 year ago

The current implementation of user-defined parameters for rs and rb timescales is functional, but requires pre-processing by calling make_rb_function_from_arrays and make_rs_function_from_arrays in pub_utils import. It would be desirable for some applications (eg parameter optimization) to allow the direct specification of vectors without precalculating the decay function.

maritsandstad commented 1 year ago

@benmsanderson This issue is sort of split in a sense, in terms of the calibration it self, I think it needs a bit of special treatment anyways, because we save so much time from precalculating the decay values, so it's being done when the cscm object is being generated, so I need a little more time to think about how to integrate that in there. For just the direct calling of an internal function, I can always make that happen under the hood (or at least optionally have it happening there...) I guess the first part of the problem (which is less easy to solve) is your main concern, however, I would like to know whether you think it is also important to solve the second problem, which is much easier to solve, but maybe more of a user friendliness issue...