Closed chrisroadmap closed 1 month ago
I actually also did this in here: #131, I think, but the changelog was something I hadn't fixed yet. Do you mind if I just merge this in there, @chrisroadmap? Was planning to put a tag to make it a minor bugfix-release
Ah my bad, I just skimmed the titles of the issues and PRs. Sure, go ahead and close this and feel free to use my change log text.
No reason to apologise, it's my fault for doing a two-issue in one thing :-)
On install using
make venv
I get the following error:If we go to the
Makefile
we have the following lines:Thus,
ciceroscm
is being successfully installed, but thejupyter nbextension
line is failing.The
jupyter nbextension
command is out of date moving to JupyterLab (https://bbs.archlinux.org/viewtopic.php?id=292074). I can't easily find a command that replaces this. However, I don't believe that the examples in thenotebooks
directory use anything fancy, so it could probably be safely removed from theMakefile
and the relevant dependencies deleted fromsetup.py
. This pull request does this.I'm using python 3.10 on Linux.
Confirmed that tests run and that notebooks perform as expected.
CHANGELOG.rst
added (single line such as:(`#XX <https://github.com/ciceroOslo/ciceroscm/pull/XX>`_) Added feature which does something
)