ciceroOslo / ciceroscm

Python version of the CICERO-SCM simple climate model/emulator
Apache License 2.0
17 stars 4 forks source link

Changing rs_function and rb_function definitions for user defined ver… #138

Closed maritsandstad closed 1 week ago

maritsandstad commented 1 week ago

…sions, so obey reasonable constraints and be definable by dictionary with coefficient and timescale vectors

benmsanderson commented 1 week ago

This works as expected, no issues found.

I do wonder whether we could simplify the dictionaries by having the same length for rs_function coeffs and timscales, and then just have the default parameter for the first mode be large enough to effectively be an infinite timescale.

Added a notebook to test old and new functionality, the following parameter values are pretty close to the old behaviour:

        "rs_function": {
                "coeffs": [0.05, 1.0,0.15,0.15,0.15],
                "timescales": [.8,3,10,80],
            },
        "rb_function": {"coeffs": [0.5, 0.25, 0.25], "timescales": [2.5, 10, 60]},