Moving reading in data out of run

ciceroOslo / ciceroscm

Python version of the CICERO-SCM simple climate model/emulator

Apache License 2.0

17 stars 4 forks source link

Moving reading in data out of run #36

Closed maritsandstad closed 2 years ago

maritsandstad commented 2 years ago

Moving the read in of data to outside of the run, also saving some time in forcing runs by not creating a concentration emissions handler instance when not needed.

[x] Tests added
[x] Documentation added
[ ] Example added (in the documentation, to an existing notebook, or in a new notebook)
[ ] Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/ciceroOslo/ciceroscm/pull/XX>`_) Added feature which does something)

maritsandstad commented 2 years ago

Solving #32

maritsandstad commented 2 years ago

@benmsanderson, I asked you to review, partially because reviewing is a good thing, but also because this will likely break your notebook(s) as I have change the run setup so more configurations need to be sent to the instance creation and less to the actual run...