search

ciceroOslo / ciceroscm

Python version of the CICERO-SCM simple climate model/emulator
Apache License 2.0
19 stars 4 forks source link

check_pamset returns warning on undefined parameters, even if parameters are defined #44

Closed benmsanderson closed 2 years ago

benmsanderson commented 2 years ago

check_pamset is called twice in concentrations_emissions_handler

first time on initialisation (line 324), user defined parameters have not been set yet, and the model returns a warning

second time (line 386), user defined parameters are implemented in the context of reset_with_new_pams

check_pamset also needs 'emstart', 'nystart' and 'nyend' in required dictionary (line 161)

benmsanderson commented 2 years ago

Solved by PR #48