Use pybadge and remove internal svg code

morapet commented 2 years ago

Summary

Closing Issues

Use Fixes #XXXX or Closes #XXXX to autoclose an associated issue.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Improvements to existing code, such as refactoring or optimizations (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

cicirello commented 2 years ago

What is the issue that is motivation for this PR?

morapet commented 2 years ago

The motivation was to add possibility to change badge text as also mentioned in one of the issues here, and also share the code. If you do no want to switch to the pybadge, then I can close the PR and not fix it further ...

cicirello commented 2 years ago

Oh I see. I actually have a revision of the badge generation that calculates left side label width that I haven't gotten around to merging. That will make adding support for custom labels without introducing a dependency easy. It is in a branch I have locally. I'll merge it now. It's 90% of the way to resolving that issue.

cicirello commented 2 years ago

Closing since issue now addressed in another way.

cicirello / jacoco-badge-generator