cicku / libproxy

Automatically exported from code.google.com/p/libproxy
GNU Lesser General Public License v2.1
1 stars 0 forks source link

Libproxy does not parse NO_PROXY correct when the line contains spaces #166

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use /etc/sysconfig/proxy
2. Add a NO_PROXY line which contains spaces

What is the expected output? What do you see instead?

The problem is that the NO_PROXY line is not parsed correctly when it contains 
spaces. They're not trimmed away which leads to this output (testcase, code 
taken from proxy_factory::_get_proxies()):

ignorstr: 'localhost'
ignorstr: ' 127.0.0.1'
ignorstr: ' 192.168.133.42'
ignorstr: '192.168.133.43'

What version of the product are you using? On what operating system?
libproxy-0.4.6/7 on openSUSE 11.4

Please provide any additional information below.
See also openSUSE bug report at 
https://bugzilla.novell.com/show_bug.cgi?id=679322

Original issue reported on code.google.com by christia...@googlemail.com on 8 Aug 2011 at 7:21

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by dominiqu...@gmail.com on 8 Aug 2011 at 10:05

GoogleCodeExporter commented 9 years ago
A fix has been commited as r821.

the diff has been applied to your main.cpp to verify the result and shows as 
expected:
> ./a.out 
ignorstr: 'localhost'
ignorstr: '127.0.0.1'
ignorstr: '192.168.133.42'
ignorstr: '192.168.133.43'

Original comment by dominiqu...@gmail.com on 8 Aug 2011 at 3:50