search

cicscareers / 320-S20-Track1

Integration Track 1
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

issue with the props passed from appts.js to AppointmentCard.js #378

Open shashanklal01 opened 4 years ago

shashanklal01 commented 4 years ago

Hey, I was working on one of the tasks on the front end, and there seems to be an issue with the props passed from appts.js to AppointmentCard.js. Some of the values being passed in are being received as null when a new appointment is being created. I reached out to Sean Powell who said it might be a lambda issue, so it would be great if this could be resolved! thanks @victoriacaruso

victoriacaruso commented 4 years ago

Could you explain the issue you are having? because from looking at the props that are passed as null from the picture in slack, they are the cancel reason, medium and promoter score, but these are all valid to be null when creating an appointment because if you look at cancelled it is false, therefore there is no cancel_reason. If the appointment gets cancelled the cancel_reason will then be updated based on the input. Similar with promoter_score, the person might have set their score to not be viewable which is why this would be null, and im pretty sure a medium isnt required for an appointment either but an additional thing if they wanted it specified when created, like for example right now we might have a medium as zoom because we are all remote, which in that case the medium wouldnt be null, but in this case, it is listed the location is LGRC which is why we have medium as null.