Originally, I had put up PRs to add prettier + prettify the entire codebase, and the same for eslint. Neither of these PRs will be merged because of inevitable merge conflicts. These PRs will be closed.
[ ] Step 2: all devs pull from master + run npm install in Client/
From this point on, the commit hook will auto-format any staged files that we try to commit. For example, if I make a 1-line change to appts.js, and try to commit that change, then prettier + eslint will auto-format that module. This will prevent future formatting & lint errors, without retroactively reformatting the entire codebase, causing a bunch of conflicts.
[ ] Step 3: once all complex FE branches that pre-date prettier + eslint have been merged into master, we will retroactively run prettier + eslint on all of /Client/src.
Sounds good, let me know if anyone runs into any issues.
Tips:
Run npm install in /Client after pulling
If prettier ends up formatting a file that causes a bunch of annoying conflicts & we need to merge, then you can just add the file to the /Client/.prettierignore file
Review Instructions: FYI
Adjascent PRs
Originally, I had put up PRs to add prettier + prettify the entire codebase, and the same for eslint. Neither of these PRs will be merged because of inevitable merge conflicts. These PRs will be closed.
Rollout plan
npm install
inClient/
From this point on, the commit hook will auto-format any staged files that we try to commit. For example, if I make a 1-line change to appts.js, and try to commit that change, then prettier + eslint will auto-format that module. This will prevent future formatting & lint errors, without retroactively reformatting the entire codebase, causing a bunch of conflicts.
/Client/src
.Tools & links