cicscareers / 320-S20-Track1

Integration Track 1
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Prettier+ eslint + lint-staged + husky without changes #428

Closed mattrheault closed 4 years ago

mattrheault commented 4 years ago

Review Instructions: FYI

Adjascent PRs

Originally, I had put up PRs to add prettier + prettify the entire codebase, and the same for eslint. Neither of these PRs will be merged because of inevitable merge conflicts. These PRs will be closed.

Rollout plan

From this point on, the commit hook will auto-format any staged files that we try to commit. For example, if I make a 1-line change to appts.js, and try to commit that change, then prettier + eslint will auto-format that module. This will prevent future formatting & lint errors, without retroactively reformatting the entire codebase, causing a bunch of conflicts.

Tools & links

mattrheault commented 4 years ago

Sounds good, let me know if anyone runs into any issues.

Tips: