search

cicsdev / cics-nodejs-invoke

Sample Node.js application that uses the invoke API from the ibm-cics-api module to call COBOL programs included in the CICS® catalog manager
Apache License 2.0
6 stars 10 forks source link

Change URL for license #10

Closed markcocker closed 3 years ago

markcocker commented 3 years ago

Change URL to MIT to https://github.com/twbs/bootstrap/blob/main/LICENSE

Resolves #9

markcocker commented 3 years ago

I tried updating Bootstrap components to https://github.com/twbs/bootstrap/releases/tag/v4.6.0 but this caused the catalog to be displayed in the browser as a single column, the menu wasn't displayed correctly, and the pop-up to order an item was oversized. These are the Bootstrap 4.6 components I tried replacing:

cp ~/Downloads/bootstrap-4.6.0-dist/css/bootstrap.css projects/cics-nodejs-invoke/public/assets/css
cp ~/Downloads/bootstrap-4.6.0-dist/js/bootstrap.js projects/cics-nodejs-invoke/public/assets/js
cp ~/Downloads/bootstrap-4.6.0-dist/js/bootstrap.min.js projects/cics-nodejs-invoke/public/assets/js

So going from 3.1 to 4.6 is not a drop-in replacement and will need dev effort to fix. I don't have the front-end skills to do that so this PR is sticking with 3.1 and amending the URL to the MIT license.

PhilWakelin commented 3 years ago

Changes look good