Allow setting standard filter or loading filter from disk

cicwi / SliceRecon

This repository has moved to:

https://cicwi.github.io/RECAST3D

GNU General Public License v3.0

6 stars 4 forks source link

Closed dmpelt closed 4 years ago

dmpelt commented 4 years ago

WIP, but already wanted to open a PR for review. It should already work though, it is mostly a matter of testing it properly.

At some point we should probably add a way of changing the filter through zeromq, but that requires additional changes to TomoPackets.

jwbuurlage commented 4 years ago

Great that you found the time to implement this! I'll have a more detailed look at the code changes later.

This reminds me that I should set up a clang-format file to make sure all the formatting is consistent between different contributors.

dmpelt commented 4 years ago

Just tested it with sirt-like filters, and it seems to work fine! I am fine with merging this if you are also OK with it.

I tried to get the formatting roughly similar to the existing code, but if you want me to change anything, let me know.

jwbuurlage commented 4 years ago

Thanks again! The code looks fine. I’ll happily merge this 😁