Uninitialized flat field problem, sino buffer address type

cicwi / SliceRecon

This repository has moved to:

https://cicwi.github.io/RECAST3D

GNU General Public License v3.0

6 stars 4 forks source link

Closed adriaangraas closed 5 years ago

adriaangraas commented 5 years ago

There are two minor problems hopefully fixed here.

If no flats/darks have been sent, flat_fielder_ remains zero-filled and the reconstructions never show up.
row * cols * group-size may exceed the 32-bit type, become negative/incorrect, and cause a segfault. Is long the appropriate type?

jwbuurlage commented 5 years ago

Thanks! The correct type would be std::size_t.

adriaangraas commented 5 years ago

Good to know, updated.