cicwi / flexTOMO

ASTRA-based cone beam tomography reconstructions
https://cicwi.github.io/flexTOMO/
Other
5 stars 5 forks source link

No contiguity / data type check in reconstruction routines #5

Closed askorikov closed 2 months ago

askorikov commented 2 years ago

The contiguity and data type check (already implemented as _check_contiguous_) is not called in reconstruction routines like SIRT, EM, PWLS and FISTA (but this check is done in forwardproject and backproject functions). This leads to errors on the Astra level.

askorikov commented 2 years ago

For now it is decided to keep the current behavior, i.e. leave the contiguity / data types checks to Astra, avoiding implicit conversion / copies within the _check_contiguous_ function (which is critical for working with big datasets).