cid-harvard / atlas-economic-complexity

[DEPRECATED] The Atlas online is a powerful interactive tool that enables users to visualize a country’s total trade, track how these dynamics change over time and explore growth opportunities for more than a hundred countries worldwide.
http://atlas.cid.harvard.edu
81 stars 40 forks source link

Get rid of hardcoded year limits in codebase #299

Closed makmanalp closed 9 years ago

makmanalp commented 9 years ago

In many parts of the code, we have hardcoded numbers that specify the default year or year ranges that a page loads on. It would be much cleaner to have these in the django settings file. Especially since it's a huge pain every time we update the data.

One caveat is that for HS4 the years go 1995 to 2012, and for SITC they go from 1970ish to 2010 (up to 2013 soon).

A good place to start looking for clues as to where to find these is looking at the differences between these two branches here (scroll down):

https://github.com/cid-harvard/atlas-economic-complexity/compare/beta...marcela_japan_2013

Those are all probably places where we could be using a variable from settings or a function or something so that we don't have to modify all those places again.