Terminal colors

[eemed]

Terminal colors should be different currently many of them are black. For example using ag with the current settings looks like this: The blocks are the matched text.

[cideM]

The thing is that many terminal apps sometimes use colors in strange ways which results in almost impossible to solve situations, especially with regards to light themes. In this case for example it would be good to know what Ag is using so that it results in this kind of highlight.

Also thanks for all your super cool contributions, would it be okay if I add you as a Contributor in the README?

[eemed]

You can add me as a contributor. I agree that light themes can be problematic, but we should at least give them a chance by making the colors different. The end result may not be perfect with all programs but most should be fine.

[cideM]

Yup but for that we need to first figure out why this looks so broken, as in which combination of terminal colors results in this output.

[eemed]

The issue is with the 4th terminal color that is yellow normally. Here is an example with tomorrow light themes yellow color

Color: yellow                  #eab700    ~
...
Term colors: black red green yellow blue black black black
Term colors: black red green yellow blue black black black

I personally think a good solution would be to take for example tomorrow light colors and tweak them a little if they don't look nice.

[cideM]

I have 2 days off so I'll tackle this tomorrow and/or friday

[cideM]

I think I can fix this tomorrow by simply using the colors already in the theme for git diffs and errors and adding whichever colors are missing

[cideM]

I pushed a commit which adds the 2 missing colors magenta and cyan and uses existing colors for the rest. Didn't test this extensively but it should hopefully be better than what's used for Term colors right now