search

cideM / yui

A minimal Vim/Neovim color scheme inspired by Dieter Rams
MIT License
135 stars 7 forks source link

feat: support Telescope #30

Closed mambusskruj closed 1 year ago

mambusskruj commented 1 year ago

For now it's just better representation of search query. Basically, this is an inverted logic for Search and CurSearch. In my opinion, inverted colors better suits Telescope's fuzzy searching.

But you, as theme author, can change it as you want ofc.

I also suggest to review other default Telescope's highlights, provided here: https://github.com/nvim-telescope/telescope.nvim/blob/master/plugin/telescope.lua#L11

May be that search counter is too bold, etc.

Resolves: #28

Screenshot 2023-04-05 at 17 36 35

P.S. For contributing purpose, consider .editorconfig (same indentation type, so on). Neovim supports it by default.

mambusskruj commented 1 year ago

Just realized, you'll need to push in forked repo. I think, better option is to create new pull request and just use my changes. Or I could do my best to review and implement some other changes related to Telescope's highlights.

Anyway, I invited you in a forked repo.

cideM commented 1 year ago

I think this already looks really good, thank you so much! I'll definitely take a look at Telescope and add a few more highlight groups for it. And the point about .editorconfig is a very good one.

mambusskruj commented 1 year ago

@cideM We also need to commit colors/yui.vim after make command. Sorry.