Closed mambusskruj closed 12 months ago
Sorry for the long radio silence! I took a look at the PR and it already looks really good. I especially like that you take the selection colors from the actual theme.
There are a few missing directives which we should add with the first PR. I think we can take the hl_groups
and convert them into a key/value table for easier access.
I also wouldn't take the primary foreground and background from the terminal colors and instead take them from the Normal
HL group maybe? Since that's what the Vim/Neovim color scheme also uses.
Lastly, let's just stick with the provided colors for this PR. The terminal colors need an overhaul anyway. So I think it would make more sense to split it like this:
Let me know how much time you have for this right now. I could also pick it up since I have a bit more time over the next 7 days.
That's right, Alacritty supports more directives, so we should try to add them:
vi_mode_cursor
search
matches
focused_match
hints
start
end
line_indicator
footer_bar
Not sure if we need to provide dim colors, because Alarcitty will calculate them automatically based on the normal
colors.
Could you please provide better understanding of hl_groups
transformation to key/value table? You want to convert yui.lua -> M.groups
?
I also wouldn't take the primary foreground and background from the terminal colors and instead take them from the Normal HL group maybe? Since that's what the Vim/Neovim color scheme also uses.
Agree.
So yeah, let's finish with first point, then merge it. Colors overhaul will be in a different PR.
I have time in thees week also, so I can stick to it.
I'll start working on this now after my recent changes. I'll use https://github.com/alacritty/alacritty/blob/master/extra/man/alacritty.5.scd as the basis and add Theme:alacritty()
Needs review, still pretty rough.