search

cideM / yui

A minimal Vim/Neovim color scheme inspired by Dieter Rams
MIT License
135 stars 6 forks source link

Support neovim 0.5 lsp highlighting #4

Closed eemed closed 4 years ago

eemed commented 4 years ago

Neovim 0.5 Lsp signs are normal color. I expected the signs to be the same color as in the screenshot. I experimeted with the following:

InfoMsg                                  purple_background purple_foreground
LspDiagnosticsError                   -> ErrorMsg
LspDiagnosticsErrorSign               -> ErrorMsg
LspDiagnosticsErrorSignFloating       -> ErrorMsg
LspDiagnosticsWarning                 -> WarningMsg
LspDiagnosticsWarningSign             -> WarningMsg
LspDiagnosticsWarningSignFloating     -> WarningMsg
LspDiagnosticsHint                    -> InfoMsg
LspDiagnosticsHintSign                -> InfoMsg
LspDiagnosticsHintSignFloating        -> InfoMsg
LspDiagnosticsInformation             -> InfoMsg
LspDiagnosticsInformationSign         -> InfoMsg
LspDiagnosticsInformationSignFloating -> InfoMsg
cideM commented 4 years ago

Thanks, I'll definitely add those since I also use Neovim. I just never use the built-in LSP. Also somehow I missed the notifications for these issues :thinking:

cideM commented 4 years ago

9

eemed commented 4 years ago

Oops I was just testing some colors on the nvim-0.5 lsp and this is how errors currently look: lspwrong The popup looks horrible with the red text in it. This is a better version: betterdiag

Modified the links to: 

InfoMsg                                  purple_background purple_foreground
LspDiagnosticsError                   -> NormalFloat
LspDiagnosticsErrorSign               -> ErrorMsg
LspDiagnosticsErrorSignFloating       -> NormalFloat
LspDiagnosticsWarning                 -> NormalFloat
LspDiagnosticsWarningSign             -> WarningMsg
LspDiagnosticsWarningSignFloating     -> NormalFloat
LspDiagnosticsHint                    -> NormalFloat
LspDiagnosticsHintSign                -> InfoMsg
LspDiagnosticsHintSignFloating        -> NormalFloat
LspDiagnosticsInformation             -> NormalFloat
LspDiagnosticsInformationSign         -> InfoMsg
LspDiagnosticsInformationSignFloating -> NormalFloat
cideM commented 4 years ago

Thanks fixed. At some point I should really look into where all these HL groups are used