ciderapp / Apple-Music-Electron

Apple Music Electron is now deprecated. See our new project Cider https://github.com/ciderapp/Cider
https://cider.sh
MIT License
840 stars 64 forks source link

[Enhancement] Connect to last.fm button instead of a link to the wiki #223

Closed Donnnno closed 2 years ago

Donnnno commented 2 years ago

Hi, first of all, great work! Thanks for doing this! :^)

Is your feature request related to a problem? Please describe. Having to go to the wiki to open another link to generate a Last.fm API key.

Describe the solution you'd like A button instead of a link to the wiki that lets users go to the Last.fm API key generator (It should probably open the default browser because users are most likely already logged in there)

coredev-uk commented 2 years ago

The only way we can currently do this is by creating a button inside the AM interface, i.e. where the Discord button is. We cannot directly interact with the settings menu, unfortunately. And in regards to how it can be done, we can just use JS's API utility and just fill the application configuration with the callback.

Donnnno commented 2 years ago

Ah, okey. The solution sounds pretty good tho.

Thanks!

quacksire commented 2 years ago

JS's API utility and just fill the application configuration with the callback.

I'm thinking ame://auth/?{last.fm callback stuff}

coredev-uk commented 2 years ago

Resolved in 578d21f

hans-juergen commented 2 years ago

So the method of copying & pasting the auth key described on the wiki page for Last.fm is outdated, and there is a button for directly connecting to your Last.fm account now? Maybe you should update the wiki page then.

coredev-uk commented 2 years ago

The wiki page is there for anyone who still uses 2.5.0

quacksire commented 2 years ago

yes

On Dec 18, 2021, at 12:16 AM, Hans-Jürgen @.***> wrote:

 So the method of copying & pasting the auth key described on the wiki page for Last.fm is outdated, and there is a button for directly connecting to your Last.fm account now?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.

hans-juergen commented 2 years ago

I see, thanks for clarifying. I posted on the Last.fm subreddit today about the internal scrobbling feature of Apple Music Electron, that's why I wanted to be sure: https://www.reddit.com/r/lastfm/comments/rj1a42/apple_music_electron_with_internal_scrobbling/ It would be great if your app could also play local music files and scrobble them, because Last.fm users often report problems when using iTunes on Windows or macOS.

coredev-uk commented 2 years ago

I've opened a new issue on Cider, hopefully this could be possible in future iterations of the app.