search

ciderapp / Apple-Music-Electron

Apple Music Electron is now deprecated. See our new project Cider https://github.com/ciderapp/Cider
https://cider.sh
MIT License
840 stars 64 forks source link

[BUG] iTunes Inspired theme makes account button unclickable #383

Closed vladaad closed 2 years ago

vladaad commented 2 years ago

Describe the bug The account/preferences button is not clickable when the iTunes inspired (MacOS Style) theme is selected while Application Frame is disabled.

To Reproduce

  1. Open the app with default settings
  2. Go to preferences
  3. Select the iTunes Inspired (MacOS Style) theme
  4. Attempt to click the account button

Expected behavior The account button is clickable (or the theme forces the application frame to be MacOS-style)

Screenshots Video

Environment Information

Additional context Might be an oversight with the MacOS-inspired theme not also enabling the correct application frame.

Have you followed the troubleshooting guide and checked for any outstanding/pinned issues that can help? Troubleshooting guide can be found here. Yes

Log File main.log

N0chteil commented 2 years ago

https://github.com/Apple-Music-Electron/Apple-Music-Electron-Themes/blob/5e84153c72ce200cd7361b68ea6b2b493793c286/itunes_macos.css#L201

width: calc(100% - 90px); must be changed to width: calc(100% - var(--windowsChromeWidth));

vapormusic commented 2 years ago

https://github.com/Apple-Music-Electron/Apple-Music-Electron-Themes/blob/5e84153c72ce200cd7361b68ea6b2b493793c286/itunes_macos.css#L201

width: calc(100% - 90px); must be changed to width: calc(100% - var(--windowsChromeWidth));

Please make a PR of this