ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
153 stars 2 forks source link

[Bug]: XML character entities appearing in lyrics #107

Closed numanumaa closed 1 year ago

numanumaa commented 1 year ago

Preflight Checklist

What operating system are you using?

Windows (Only Supported)

Build Details

https://discord.com/channels/843954443845238864/905459703092490340/1087772548609093662

Operating System Version

Windows 11 22H2

Describe the Bug

Occasionally XML character entities will appear in lyrics. The most obvious example I can think of is in "Slipknot - Psychosocial," where the characters < and > appear as &lt; and &gt; respectively.

image https://music.apple.com/us/song/psychosocial/926187670

As another example, in "Ho-Kago Tea Time - Go! Go! Maniac," & will appear as &amp;.

image https://music.apple.com/us/song/go-go-maniac-from-k-on/367317085

On Apple Music (Android) the lyrics appear as expected.

Steps to Reproduce

  1. Play a song that uses some of XML's special characters within its lyrics (try the above)
  2. Review lyrics for the potential issue

Anything else?

No response

d3rpp commented 1 year ago

Yep, can reproduce. I think i know where this is coming from but the file that handles lyrics is 5 files totalling 1331 lines of wizard magic so idk how to fix

d3rpp commented 1 year ago

Tagging @booploops as they wrote the lyrics code

booploops commented 1 year ago

fixed in 1d55c3dc29ae18159f8306e9a28707cb7d0f1998