[Bug]: Adding a duplicate song to a playlist doesn't warn you

TreehouseFalcon commented 1 year ago

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I have read the troublshooting FAQs and none solved my issue. ( These are outdated and may not necessarily be possible in the current app version. )

What operating system are you using?

Windows (Only Supported)

Operating System Version

Windows 11 22H2

Describe the Bug

Current behavior

Adding a song to a playlist that already appears in that playlist doesn't warn you about the duplicate status. This was a feature in Cider 1.x.

Expected behavior

There should be some sort of popup confirming that you want to add the duplicate song like there is on the Apple Music mobile client.

Steps to Reproduce

Right click a song
Hover over "Add to playlist"
Select a playlist with hundreds of songs
Repeat 1-3 for the same song and playlist
There is no warning about the selected song already existing in that playlist

Anything else?

No response

elliotjarnit commented 1 year ago

Done in latest commit, thanks for suggesting!

TreehouseFalcon commented 1 year ago

This seems to still be present on the latest clientdb build. Updated repro steps to ensure reproduction.

elliotjarnit commented 1 year ago

Are you sure you are on the latest version? This is what happens when I try to add a duplicate song:

coredev-uk commented 1 year ago

It seems dismissing the dialog causes the songs to still be added. For some reason dismissing calls the cancel function as well as dismiss, not sure why they designed it this way. So, we can either force the user to select an option or find another option for the dialog.

So if you click straight after you try and add the song, it will dismiss the dialog before its already been shown, this is probably what is happening.

TreehouseFalcon commented 1 year ago

Are you sure you are on the latest version? This is what happens when I try to add a duplicate song:

This dialog doesn't appear on the latest Sabiiro prerelease from today. I used the same reproduction steps on a playlist with over 1000 songs just a second ago and it still added the song.

coredev-uk commented 1 year ago

Resolved with https://github.com/ciderapp/project2/commit/2265fb3301255cb1d6475ab6d7a278a1d71b6416

ciderapp / Cider-2