ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
135 stars 2 forks source link

[Bug]: Listen Together does not sync up when a song finishes #395

Closed seyaidev closed 7 months ago

seyaidev commented 9 months ago

Preflight Checklist

What operating system are you using?

Windows

Build Details

2.2.0

Operating System Version

Windows 11 22H2

Describe the Bug

Listen Together does not sync up properly with listeners immediately. The host starting a song by either clicking play on the track or skipping to it works as expected; the listener will start the same song. However letting a song play to completion in a playlist and going to the next track, regardless of shuffle status, will restart the last played song for the listener instead of moving to the new song that the host is starting.

For example: Host starts Track 1 Listener follows and starts Track 1

Host lets Track 1 play to completion, and Track 2 starts Listener lets Track 1 play to completion, and Track 1 restarts

Host skips to Track 3 Listener follows and starts Track 3

I've also observed where if there is a delay between playback time on the Host and Listener (host is several seconds ahead of the listener) then when the song completes and moves to the next track on the Host it will restart early and not finish the track completely for the Listener.

I'm setting up a Listen Together party between myself and my SO who's currently in Australia so there's always latency between things we do online.

Steps to Reproduce

  1. Create a Listen Together party
  2. Have the host play a track by clicking it directly
  3. Let the song play to completion
  4. Skip to a new song

Anything else?

I attached console logs of the host/client when a new song starts by letting the last song play to completion

Listener Console when a song completes on the Host

image

Host Console when a song completes on the Host

image

Connect Device ID

No response

Build timestamp

1696295707695

coredev-uk commented 7 months ago

fixed in 2.3