Last.FM login doesn't work with RPC Server disabled

RuiNtD commented 4 months ago

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I have read the troublshooting FAQs and none solved my issue.

What operating system are you using?

Windows

Build Details

v2.3.1 built on 2/8/2024, 12:53:38 AM

Operating System Version

Windows 11 23H2

Describe the Bug

Trying to connect to Last.fm gives a "localhost refused to connect" error after clicking Allow Access if RPC Server is disabled

Steps to Reproduce

Go to settings
Click the Connectivity tab
Ensure "RPC Server" is disabled and restart Cider if needed
Click "Sign into Last.FM"
Login to Last.FM and click Allow Access.

Anything else?

Connect Device ID

No response

Build timestamp

No response

RuiNtD commented 4 months ago

Apparently this is caused by RPC server being disabled.

EDIT: I will leave this open, since Cider makes no attempt to launch the RPC server or to communicate to the user that the RPC server needs to be enabled. I've also updated the original issue.

coredev-uk commented 4 months ago

We've deployed a fix for this that enables the RPC server for Last.FM auth.

ciderapp / Cider-2