ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
125 stars 2 forks source link

Language settings not used for Apple Music content #618

Closed astatide closed 1 month ago

astatide commented 2 months ago

Preflight Checklist

Download Source

Itch

Operating System

Linux 6.8.5-301.fc40.x86_64

Commit Hash

618b467d19eab9fc0bb786c2efb1c04f7a52ed96

Connect Instance ID

not-logged-in

Build Timestamp

4/4/2024, 4:01:00 AM

Describe the Bug

My region for my Apple Store is set to Spain; however, I primarily speak English and the Cider language is set to "American English". All the Cider UI text is indeed in English; however, much of the text coming from Apple music is in Spanish (playlist names, artist biographies, search results). I'm on version 2.3.2_3 image

Steps to Reproduce

If you're not already in a non-US region, you'd have to change your region at the App Store which requires unsubscribing from everything, waiting for the remaining subscription to expire, then changing regions. I can't recommend that, but it's possible that simply changing the Cider language doesn't impact the backend (perhaps try changing it to Spanish and seeing if what comes in from Apple's backend is in Spanish or not?)

Anything else?

I'm happy to test any potential fixes. Also, the issue is not present on Apple Music on iOS; all the results there are returned to me in English, as my phone is set to that.

github-actions[bot] commented 2 months ago

Hello @astatide :wave:

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! :smiley:

astatide commented 2 months ago

For kicks, I changed my language to Hong Kong Chinese, and indeed, Cider's UI language changes... but search results, artist profiles, are still in Spanish :joy_cat:

coredev-uk commented 2 months ago

The language which API calls will return in is based your current storefront. So for the Spanish storefront the supported languages are 'es-ES', 'en-GB', 'ca'. The language setting in the Cider settings will try to apply the language you selected to the API calls given that the language is supported under the storefront.

The storefront is hard-set thought your apple Id currently. Changing this to a user-set preference may cause issues thus why it is not given.

There is logs in console when a language is applied correctly, but no notification is shown which will probably change in the future but outside that not more will be done.

And just for additional context a storefront is where media is fetched from (E.g. Browse page results, Search results etc.), these will all be adjusted to that specific country. Each storefront supports a certain list of languages.

coredev-uk commented 2 months ago

If you are interested in finding out which storefront supports which language you can find out by running this API call in console which will return an object with language codes and the supportedLanguageTags array in attributes.

(await MusicKit.getInstance().api.v3.music('v1/storefronts')).data.data

astatide commented 2 months ago

Ah, my phone is set to British English, which is probably why I don’t notice this behavior there. I’ll try and change Cider to British English and see if it works. Thanks.

astatide commented 2 months ago

Actually, I’ve set it to British English, which is supported by the store front, but it still seems to be returning results in Spanish.

astatide commented 2 months ago

Sorry, I think I’m just confused about what is “not planned” in this case, as based on what you told me it should probably likely work so long as I’ve selected a supported language, which I have done. So it doesn’t sound like an apple backend issue but instead something on the Cider end, unless Apple’s API ignores the requested language in the payload. I’m not requesting any language override or any feature like that.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 10 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This issue was closed because it has been stalled for 5 days with no activity.