ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
124 stars 2 forks source link

"Last Playlist" upon Right-Click of song Appearing as "undefined" #659

Closed sudo-thoth closed 1 week ago

sudo-thoth commented 3 weeks ago

Preflight Checklist

Download Source

Itch

Operating System

macOS 23.5.0

Commit Hash

d46a15d346cc8cc7ae5dfc5ddd19808e291e9bd7

Connect Instance ID

not-logged-in

Build Timestamp

5/30/2024, 3:00:03 PM

Describe the Bug

"Last Playlist" upon Right-Click of song and within the "add to last playlist, " the song name appears as "undefined". So It appears as "Add to Last Playlist, undefined". Only occurs after repeating "add to last playlist" a few times in repetition on multiple unique songs. image

Steps to Reproduce

How to invoke runtime error. Add a song to a new playlist via the right click->search for non-existent playlist-> click create playlist. Song A added to New playlist named "Playlist 1". Upon right click on a new song->add to last playlist appears as "Add to Last Playlist, Playlist 1". now Song B added. Now upon right clicking on a new song-> add to last playlist appears as "Add to Last Playlist, undefined" but the click action event still responds as expected adding the song to the correct "last playlist".

Hopefully this is well explained.

Anything else?

Also waiting on the Airplay Feature to be improved but thanks for everything else.

github-actions[bot] commented 3 weeks ago

Hello @sudo-thoth :wave:

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! :smiley:

coredev-uk commented 1 week ago

Very strange issue, I cannot replicate this. I will add an additional check to not display the recent playlists if there is no name for the playlist found. Other than this, as I cannot replicate it I cannot do much more.

As for Airplay, this is a very under worked feature that has essentially been abandoned since the main developer who worked on it has left and the rest of the team are focused on other areas of the app. Hopefully we can revisit it soon and one of us can get a grasp and understand it.