search

ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
124 stars 2 forks source link

Native titlebar selection no longer draws window decorations - EndeauvourOS Gnome #673

Closed corbo-we closed 1 week ago

corbo-we commented 1 week ago

Preflight Checklist

Download Source

Itch.io

Operating System

EndeavourOS Gnome Desktop

Commit Hash

098a60e1301a58f734d21064b2a2bcfc9b4b1520

Connect Instance ID

No response

Build Timestamp

1717052676223

Describe the Bug

New builds without arch name in them will not draw window decorations with window toggle set to native. Previous builds that had "arch" in the name seemed to work for this. I've updated 3 machines and they've all exhibited the same behavior.

In testing the old and new package both show the same build hash, etc. Not sure where to go from here in testing.

Steps to Reproduce

Install new build from Itch.io: cider-git-2.4.1-1-x86_64.pkg.tar.zst

Load Cider 2 and set window decorations to native.

Restart app.

Window loses controls, native controls do not show up.

Anything else?

No response

github-actions[bot] commented 1 week ago

Hello @corbo-we :wave:

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! :smiley:

coredev-uk commented 1 week ago

Native controls are set by your distro. When you enable native frame you will need to completely close the app (quit from tray if close button hide is on) and relaunch, if there is no frame given then the distro has not set one, or Electron is messing up.

corbo-we commented 1 week ago

Native controls are set by your distro. When you enable native frame you will need to completely close the app (quit from tray if close button hide is on) and relaunch, if there is no frame given then the distro has not set one, or Electron is messing up.

The previous build worked fine with Gnome. The new build does not. I have been closing it after setting native. Is there a build archive so I can grab the working one until this all gets sorted?

coredev-uk commented 1 week ago

Build archived are only available through Discord, I will try to recreate your issue on the latest and I'll let you know the outcome.

corbo-we commented 1 week ago

Please let me know if you need anything from me or would like me to test.

coredev-uk commented 1 week ago

Okay, I've just tested with the release uploaded to itch on gnome (x11) with arch. Appears to be working as intended. So what I am going to suggest is removing the config file you have and launching the app to generate a new one. You can find the config at .config/sh.cider.electron/config.json. Please ensure the app is closed before restarting after you change the setting back to native.

corbo-we commented 1 week ago

EndeavourOS has Gnome running on Wayland. I've done as requested though, and it still does not draw the native controls.

coredev-uk commented 1 week ago

I'll give wayland a try then, I'm not too sure what else it can be.

coredev-uk commented 1 week ago

Can confirm this has replicated your issue, seems either to be a bug with Electron or with Gnome on Wayland. I will mess around with the Electron version to see if downgrading can fix this.

coredev-uk commented 1 week ago

Disregard what I said previously, this was the result of a patch I made previously as having the frame enabled on wayland was causing crashing on some distros. Apparently this is fixed now or smth, I've undone the patch and it should be fixed in 2.4.2. For now I suggest using the built-in titlebar until the update is released.

Fixed in https://github.com/ciderapp/Izanagi/commit/3678aa384f05d6b37e13b9bc16280f92d702f9fa