ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
157 stars 2 forks source link

wrong left-right positioning in sing lyrics #685

Closed Waoweens closed 2 months ago

Waoweens commented 3 months ago

Preflight Checklist

Download Source

Discord

Operating System

Linux 6.9.7-arch1-1

Commit Hash

6779da05fbce6d75ecc42b365463827b7c41905e

Connect Instance ID

not-logged-in

Build Timestamp

7/3/2024, 1:43:52 PM

Describe the Bug

hi!

the left-right speaker positioning (i'm not sure what it's actually called) is wrong on Cider:

Screenshot_20240707_195244

looking at the syllable-lyrics TTML response from MusicKit, it looks like Cider is only looking for ttm:agent in the <div>s, and not the individual <p>s.

<!-- /v1/catalog/{region}/songs/590431787/syllable-lyrics -->
<!-- ... -->
<div begin="17.855" end="35.414" itunes:songPart="Verse" ttm:agent="v2">
    <!-- ... -->
    <p begin="33.306" end="35.414" itunes:key="L24" ttm:agent="v2">
        <span begin="33.306" end="33.490">And</span>
        <span begin="33.490" end="33.627">the</span>
        <span begin="33.627" end="33.960">eyes</span>
        <span begin="33.960" end="34.210">ease</span>
        <span begin="34.210" end="34.460">open</span>
        <span begin="34.460" end="34.591">and</span>
        <span begin="34.591" end="34.770">it's</span>
        <span begin="34.770" end="35.043">dark</span>
        <span begin="35.043" end="35.414">again</span>
    </p>
</div>
<div begin="35.424" end="44.387" itunes:songPart="Chorus">
    <p begin="35.424" end="36.621" itunes:key="L25" ttm:agent="v1">
        <span begin="35.424" end="35.733">From</span>
        <span begin="35.733" end="35.870">the</span>
        <span begin="35.870" end="36.203">top</span>
        <span begin="36.203" end="36.303">to</span>
        <span begin="36.303" end="36.403">the</span>
        <span begin="36.403" end="36.621">bottom</span>
    </p>
    <p begin="36.631" end="37.699" itunes:key="L26" ttm:agent="v2">
        <span begin="36.631" end="37.006">Bottom</span>
        <span begin="37.006" end="37.155">to</span>
        <span begin="37.155" end="37.446">top</span>
        <span begin="37.446" end="37.571">I</span>
        <span begin="37.571" end="37.699">stop</span>
    </p>
    <!-- ... -->
</div>
<!-- ... -->

Steps to Reproduce

  1. play a song with sing lyrics and has 2+ vocalists
  2. view sing lyrics
  3. see the positioning of lyrics are wrong

Anything else?

No response

github-actions[bot] commented 3 months ago

Hello @Waoweens :wave:

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! :smiley: