ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
153 stars 2 forks source link

Error when rating songs #732

Open KibbeWater opened 3 weeks ago

KibbeWater commented 3 weeks ago

Preflight Checklist

Download Source

Microsoft Store

Operating System

Windows

Commit Hash

3baa7bbffd664e9dfcd1847204c49a8b2eee5962

Connect Instance ID

not-logged-in

Build Timestamp

8/16/2024, 11:00:06 PM

Describe the Bug

When submitting a rating (Suggest Less), the request will return an error

https://amp-api.music.apple.com/v1/me/ratings/song/1754946760

{
    "errors": [
        {
            "id": "7LFFQCSHK4Z65CZBCO7MYO6UDE",
            "title": "Invalid Path Value",
            "detail": "Unknown resource type 'song'",
            "status": "400",
            "code": "40008"
        }
    ]
}

Steps to Reproduce

  1. Click on the three dots in the mini-player visible directly from the homepage
  2. Press the thumbs down / "Suggest Less" button, error will be seen from the network tab in the developer console

Anything else?

Error seems to stem from a small typo in the url:

URL as documented per the Apple Docs: https://api.music.apple.com/v1/me/ratings/songs/{id}

Actual URL: https://amp-api.music.apple.com/v1/me/ratings/song/1754946760

github-actions[bot] commented 3 weeks ago

Hello @KibbeWater :wave:

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! :smiley:

coredev-uk commented 3 weeks ago

What song are you directly playing? and is it from the library that you queued it or from a search/browse/listen-now page?

KibbeWater commented 3 weeks ago

When playing from my "Today's Hits" playlist, I also observed the same behavior when playing from my own personal playlists. The dislike state will be reflected in the UI but the network PUT/DELETE requests will fail.

I have attached a video demonstrating the issue below, both links are just the same video.

https://youtu.be/1xlIL6TPcss https://github.com/user-attachments/assets/e58139da-0b60-45ad-bef5-9926f5eec3dc

KibbeWater commented 3 weeks ago

Items disliked from the queue seems to have the same behavior. I forgot to mention also that the rating does not seem to load either, so the state of the "Suggest Less" button will reset on restart

github-actions[bot] commented 1 week ago

This issue is stale. If this issue is still occurring and you are on a supported version, please leave any comment (e.g. "bump") within the next 7 days and the issue will remain open. If you have any additional information that may help us resolve your issue, please include it with your comment.

KibbeWater commented 1 week ago

bump

booploops commented 5 hours ago

Resolved in 2.5.2_5