ciderapp / Cider-2

Primary public repository for Cider 2.x
https://cider.sh
188 stars 3 forks source link

Infinite Loading #780

Open JustSxm opened 2 months ago

JustSxm commented 2 months ago

Preflight Checklist

Download Source

Microsoft Store

Operating System

Windows

Commit Hash

57a19b9cfd45f52a28be6b1e8d456f73d151aa2d

Connect Instance ID

No response

Build Timestamp

2024-09-13, 10:43:51 p.m.

Describe the Bug

When searching for a query with no results, instead of showing something as "No results." we get an infinite loading spinner.

This happens as well when searching for an existing result and scrolling at the bottom

(There also seems to be 2 spinners, one quickly dissapear)

Here is a demo: https://streamable.com/k0xkm2

Steps to Reproduce

Here is a demo: https://streamable.com/k0xkm2

Anything else?

No response

github-actions[bot] commented 1 month ago

This issue is stale. If this issue is still occurring and you are on a supported version, please leave any comment (e.g. "bump") within the next 7 days and the issue will remain open. If you have any additional information that may help us resolve your issue, please include it with your comment.

JustSxm commented 1 month ago

bump

coredev-uk commented 1 month ago

Please ensure your application is up-to-date. There was an outage with the Apple Music API earlier on, but we believe this is resolved.

JustSxm commented 1 month ago

Still happening. It is up to date. I believe if there is no result the application just not remove the loading

coredev-uk commented 1 month ago

Have you tried resetting your settings and/or checked your storefront settings found in Settings > General > Apple Music > storefront, please ensure this value is either set to 'auto' if available or your primary account region.

If the above did not work, please could you provide the following:

  1. The outcome of what happened when you completed the same action on the Apple Music website
  2. What is outputted in your console (Ctrl+Shift+I -> console) when you attempted this actions
  3. What type of Apple Music subscription you have
JustSxm commented 1 month ago

If you search "tasdasdasdasdasd" on Apple Music u'll get a no result. Cider just loads infinitly instead of just saying no results. When you search something that exists you will also get the spinner at the bottom when there is no more results to load

image

You just dont handle those in your code