ciderapp / Cider

A new cross-platform Apple Music experience based on Electron and Vue.js written from scratch with performance in mind. 🚀
https://cider.sh
GNU Affero General Public License v3.0
7.15k stars 344 forks source link

[Bug]: Every time I restart app i see onboarding screen and need to login again as well #1494

Closed iamruletik closed 1 year ago

iamruletik commented 1 year ago

Describe the Bug

Every time I restart app i see onboarding screen and need to login again as well

Steps to Reproduce

  1. Just restart the app

Environment Information

How did you download the software?

GitHub

Anything else?

No response

Code of Conduct

Disclaimer

coredev-uk commented 1 year ago

Did you try a clean install?

XTREME1738 commented 1 year ago

got this happening to me aswell

SentixDev commented 1 year ago

same here

iamruletik commented 1 year ago

Did you try a clean install?

I tried. Didn't work. But i tried install latest alpha and it's no longer an issue. But stable release still didn't work out for me.

icerain9247 commented 1 year ago

same for me

coredev-uk commented 1 year ago

Just use the latest release for now then. Not sure what would be causing this.

Mikolaj-Walkowiak commented 1 year ago

I have the same problem, tried reinstalling to a different drive, clean install, both master and stable branches - nothing. If it helps anything my log in window doesn't close / continue button is doing nothing. obraz

veilin commented 1 year ago

Same issue here. This is really irritating.

fherenius commented 1 year ago

Having the same on Linux. Which branch are the alpha builds? The docs still refer to the develop branch but it no longer seems to exist.

coredev-uk commented 1 year ago

The main branch is alpha.

fherenius commented 1 year ago

Thanks! Then I'm already on the Alpha branch and the issue still exists, unfortunately.

For reference, it seems Apple at least recognizes it as the same browser since I don't have to enter the verification code every time (only on a clean install). If I remember I'll try to see where it goes wrong :)

mbures commented 1 year ago

I also see this. I am using snaps on Ubuntu using the most recent alpha release. I have tried the instructions to do a clean remove and have also removed/reinstalled with the snap --purge option but it has no effect. This has been affecting me for a while. I believe the stable(OLD) version in the snap store works correctly but none of the betas/alphas I have tried since do.

Is there anything that I can check on my system? Files that should stay/be created, etc?

ilyshirai commented 1 year ago

fyi uninstalling Cider won't remove its config, not sure how snaps work, but you could try to remove ~/.config/Cider folder if exists.

mbures commented 1 year ago

Yeah - I tried the --purge option because I don't have an entry in ~/.config for Cider.

ThinkChaos commented 1 year ago

Same issue here.

I also can't access anything in the app after logging in: the app just shows its loading screen forever. Is this the case for others or can you actually use the app?
Clicking on the cider logo opens the login page again. Reloading the main Cider view also triggers the login flow.

If I click "Account Settings" and login there, it does show me the account settings properly.

Test with latest stable (1.5.9) and latest nightly (v1.6.0-beta.37) with a clean install each time. Logs from nightly:

``` [18:29:10.290] [info] [AppEvents] App started [18:29:10.455] [info] [PluginHandler] Loaded plugins: [ 'chromecast.js', 'discordrpc.js', 'lastfm.js', 'menubar.js', 'mpris.js', 'thumbar.js', 'webNowPlaying.js' ] [18:29:10.496] [info] [AppEvents] App ready [18:29:10.497] [info] [Cider] Application is Ready. Creating Window. [137:1109/182910.531010:ERROR:sandbox_linux.cc(376)] InitializeSandbox() called with multiple threads in process gpu-process. [18:29:11.838] [info] WebSocketServer started on port: 26369 [18:29:11.841] [info] [Cider][Widevine] Status: { oimompecagnajdejgnnjijobebaeigek: { name: 'Widevine Content Decryption Module', status: 'updated', version: '4.10.2391.0' } } [18:29:11.842] [info] { auxAttributes: { amdSwitchable: false, canSupportThreadedTextureMailbox: false, glResetNotificationStrategy: 0, inProcessGpu: true, initializationTime: 0, jpegDecodeAcceleratorSupported: false, oopRasterizationSupported: false, optimus: false, passthroughCmdDecoder: false, sandboxed: false, softwareRendering: false, subpixelFontRendering: true, videoDecodeAcceleratorFlags: 0, visibilityCallbackCallCount: 0 }, gpuDevice: [ { active: false, cudaComputeCapabilityMajor: 0, deviceId: 0, vendorId: 0 } ] } [18:29:11.843] [info] From here can you check for real changes, the initial scan has been completed. [18:29:11.843] [info] Cider client port: 9000 [18:29:11.844] [info] Cider remote port: 6942 [18:29:11.845] [info] remote broadcasted [18:29:12.250] [error] [DiscordRichPresence][connect] Error: Could not connect [137:1109/182913.465120:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times! [137:1109/182926.102207:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 2 times! [137:1109/182941.389944:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 3 times! ```

Anything I can do to help debug this?

EDIT: apparently 1.6.0 is released so I tried that but same problem. For some reason https://github.com/ciderapp/cider-releases doesn't consider 1.6.0 the latest release so it's confusing.

d0lb33 commented 1 year ago

Clean uninstall and 1.5.9 fixed it for me!

Continue button still doesn't close the login prompt though!

Mikolaj-Walkowiak commented 1 year ago

For me it's still happening, the initial setup remembers my language/visual/audio settings but I need to click through and login each time I close and open the app.

kode54 commented 1 year ago

Still happening with 1.5.9-1 from AUR package cider-bin, and cider package 1.5.9-4. Installing version 1.6.0.beta.67-1 from the cider-git package results in an app that won't even open. I have tried deleting ~/.config/Cider each launch.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

NeutronicMC commented 1 year ago

The same thing happens to me every time I launch on 1.5.9 with arch linux

NeutronicMC commented 1 year ago

Okay, I found the source of the issue. I have a database for development that uses port 9000, and whenever Cider isn't able to bind to that port, it shows the onboarding/login screen. If I do nothing, close Cider, stop the database, and then re-open the Cider, it no longer shows the onboarding screen and behaves like normal. I've tested this multiple times and it behaves this way consistently.

Mikolaj-Walkowiak commented 1 year ago

I can confirm it does the same thing for me as well - I have a docker container on port 9000 - when it's active, I see the onboarding screen, and when disabled, it opens up without a login prompt.

Is there a plan to fix this or no chance?

fherenius commented 1 year ago

@Mikolaj-Walkowiak @NeutronicMC Nice catch! I looked at the code and I think the issue originates from this line: https://github.com/ciderapp/Cider/blob/cb3a3053baf51c78538eb1d0a21f34086a563c16/src/main/base/browserwindow.ts#L399

I just tested it by setting the CIDER_PORT variable in the terminal from where I was launching Cider to some available port and Cider now works as expected. So there's already a workaround in place!

@coredev-uk Would be nice to add this to the documentation! Ideally of course a check if port 9000 is already taken or not and generating a warning in this case or taking another port. If I have time this weekend I might be able to write a PR for this.

coredev-uk commented 1 year ago

Hi, sorry for the lack of responses on this. The team has been fully focused on Cider 2, with a lot of c1 issues being disregarded. There is already a check in place for the client port to check if it is available, however the range of ports that we check is not that large, thus if 9000 is taken and no environment var is passed it will randomise. I will make a commit making the port a option within the 9000-9999 range.

Other than this, there are a few other areas in Cider where the port is incorrectly set (like in chromecast) which default to 9000. This will be resolved soon.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

ThinkChaos commented 1 year ago

Any chance you can use port 0 to let the OS assign a random free port?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

coredev-uk commented 1 year ago

Moving the application to port 0 may work. The original suggestion that I was proposing requires a conversion to node ESM modules, which requires a refactor of the entire repository.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.