search

cidertool / cider

Submit your builds to the Apple App Store in seconds
https://cidertool.github.io/cider
GNU General Public License v3.0
26 stars 0 forks source link

Remove data races by avoiding global CLI logger #43

Closed aaronsky closed 3 years ago

aaronsky commented 3 years ago

Refactor logging implementation to avoid problematic use of global logger.

codecov-commenter commented 3 years ago

Codecov Report

Merging #43 (87642a6) into main (8b746fa) will decrease coverage by 0.92%. The diff coverage is 64.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   81.79%   80.87%   -0.93%     
==========================================
  Files          36       38       +2     
  Lines        2324     2337      +13     
==========================================
- Hits         1901     1890      -11     
- Misses        326      345      +19     
- Partials       97      102       +5
Impacted Files Coverage Δ
internal/clicommand/completions.go 94.73% <ø> (ø)
internal/clicommand/release.go 68.25% <0.00%> (-0.73%) :arrow_down:
internal/client/assets.go 44.07% <0.00%> (-0.32%) :arrow_down:
internal/client/client.go 86.84% <ø> (ø)
internal/git/git.go 100.00% <ø> (ø)
internal/log/log.go 0.00% <0.00%> (ø)
internal/parallel/group.go 100.00% <ø> (ø)
internal/pipe/git/git.go 97.56% <ø> (-2.44%) :arrow_down:
internal/template/template.go 100.00% <ø> (ø)
internal/shell/shell.go 84.09% <53.33%> (-15.91%) :arrow_down:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d09b23b...87642a6. Read the comment docs.