ddooley
commented
4 years ago This pr I should have marked WIP. Its meant to be a design iteration to be discussed. I wrote it in a day.
- I tried to follow your / Google code pattern but neglected a few things here and there, so thanks for noting those spots.
- Re. modal - the alert isn't something a user would see normally; it was more a programmer level message. but I've done the change.
- Re. template via URI. Its a feature I popped in there to show how we can handle templates that don't necessarily appear in menu system.
- Re. display/selection of templates in menu vs in setup vs. title somewhere on screen. Totally a point of discussion as I mentioned in the pr. A decision we can all dwell over.
- Re. mature code base. The main problem with the current code base was that the startup part had a variety of jquery html handler connections that are only run once, mixed in with html setup stuff that needed to be rerun on each template load. So I separated those out. Secondly I had to split into a few stages the code that loads the template json/js and then do stuff after the load. I think you would discover that you would have to do the very same things, so it wasn't a capricious reorganization.
- As to the suggestion of a TEMPLATE data structure, with functions inside it and data.js too, I agree, we can head in that kind of direction. That exposes that the code could be refactored in a more modular way as a class with data components, initializers etc. I didn't have time to go that far.
Just for preliminary comments. May hide Template menu until other templates are ready.