cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
92 stars 25 forks source link

Revert "Make header check more robust" #198

Closed ddooley closed 3 years ago

ddooley commented 3 years ago

Reverts Public-Health-Bioinformatics/DataHarmonizer#196

On the surface this seems to avoid miss-match on fields with extra spaces in labels. But the algorithm for aligning data columns to template still must run - and it currently depends on exact string match. See main.js mapMatrixToGrid function unmappedHeaders code. So that code needs to be changed too, otherwise each space-mismatched header column of info won't be uploaded.

(Note that consequently the template's normalized field names, not the user's uploaded field with extra spaces, will be used when saving the data).