search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
92 stars 25 forks source link

delete or clear unwanted rows #208

Closed turbomam closed 3 years ago

turbomam commented 3 years ago

I did a search-in-repository but couldn't find "delete" anywhere

ddooley commented 3 years ago

Right - the handsontable interface doesn't have a delete row UI by default. But we could add "delete" key click -> popup confirmation to delete a selected range of rows.

turbomam commented 3 years ago

I think flashing red text will be required for that

ddooley commented 3 years ago

Yes, with a dialog inserted before that popup warning that users may encounter detrimental health effects of seeing the next dialog, and do they wish to cancel?! :)

dehays commented 3 years ago

@ddooley Unless I am misunderstanding, Handsontable does provide this in the context menu functions. (We/JGI allows remove row and insert rows in a few of the places we use HOT.). Looks like this in the HOT config object:

contextMenu: ["remove_row"],

ddooley commented 3 years ago

Well, that was the easiest issue resolution ever! Its now on master. I think add row and delete row are useful too so I'll add them in. Somehow the context menu functionality was missed in our first round of programming.

Thanks!