search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
91 stars 25 forks source link

Does the main branch still use data.tsv as input? #243

Closed turbomam closed 2 years ago

turbomam commented 2 years ago

I'm developing in https://github.com/microbiomedata/DataHarmonizer. We are still using data.tsv to specify our DataHarmonizer interfaces. We might switch to whatever methods you have for using LinkML as input after February.

Here's a summary of your commits that we don't have yet. If I just take all of these, will the main branch still have script/make_data.py?

turbomam commented 2 years ago

https://github.com/microbiomedata/DataHarmonizer/compare/master...cidgoh:master

ddooley commented 2 years ago

Yes it does! And main branch still uses make_data.py . Not sure about the "summary of your commits that we don't have yet", but besides one master commit for issue #66 , the current release has all commits put towards master; the WIP LinkML data structure branch doesn't use data.tsv and has many commits towards it but when they become the main source code, it would be expected that information sourced from data.tsv would be sourced directly from linkml templates instead.

ddooley commented 2 years ago

Ah, yes, you can take all those commits. They are just about specific template vocabulary updates except the last one which is inconsequential at moment too.

turbomam commented 2 years ago

Thanks @ddooley