search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
91 stars 25 forks source link

Scrolling and jumping unreliable after saving large sheet #248

Closed turbomam closed 2 years ago

turbomam commented 2 years ago

"large" = greater than 100 column

Frozen template and sample data file (in template/dev/exampleInput/soil_biosample_valid.tsv)

ddooley commented 2 years ago

So I wasn't able to duplicate this problem on Chrome 97.0.4692.71 using the sample data set. You were using chrome at the time you showed me that test right? Or is it another browser this is showing up on? We may need to have another visual demo.

I have made a few small adjustments to main.js and main.css which seem to have fixed the horizontal and vertical scroll problem misalignment with first frozen column. As well I turned on the feature that allows users to set widths of columns. But I tested your template with and without these improvements and couldn't see the problem you showed me.

turbomam commented 2 years ago

OK, I've asked NMDC team members to interactively test the DH you and I were looking at. I'll ask them to record their OS, browser name and detailed version. Can they post their findings here, or would you prefer for me to aggregate/gatekeep?

ddooley commented 2 years ago

I saw the bug on your browser so I'm not sure you need to cast the testing net further. You showed it to me on Chrome right? Did you have a big data set? I tried with your 2 line test data set but it seemed fine.

turbomam commented 2 years ago

I haven't tried it except with the two sparse rows. I've been shifting between a couple of different computers, so I'll try once more on two of them and report the results. Last time it was Chrome on Ubuntu Linux 20 but I don't remember the Chrome version.

ddooley commented 2 years ago

Also I saved file as tsv and as xlsx formats. Let me know which format you saved as and then found the problem. Also, when you do replicate the problem, could you re-try with the nowrap and ellipsis CSS adjustment in https://github.com/cidgoh/DataHarmonizer/issues/66 :

#grid table.htCore > tbody > tr td:nth-child(2) {
    border-right: medium solid gray;
    white-space: nowrap;
    text-overflow: ellipsis;
}

There is a possibility that this might helps part of the problem.

ddooley commented 2 years ago

Hopefully this is resolved now?

turbomam commented 2 years ago

I have been keeping an eye on the scrolling and everything has been OK for me recently. Additional people are testing now. Can I give you more feedback early next week?

turbomam commented 2 years ago

Sorry, I didn't every try (or respond to) your https://github.com/cidgoh/DataHarmonizer/issues/248#issuecomment-1016670408)

ddooley commented 2 years ago

You bet!

ddooley commented 2 years ago

It appears that this isn't a problem any more? I'll close in a few days unless issue is rekindled.