collaborate on linkml branch

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.

MIT License

91 stars 25 forks source link

collaborate on linkml branch #267

Closed turbomam closed 2 years ago

turbomam commented 2 years ago

[x] linkml.py behavior for creating the template menu in the menu.js?
[x] section definition and ordering
[ ] what slot attributes are applied to the DH interface, esp help dialogs
[x] which classes should be considered eligible to appear in the templates menu?
[ ] contribute Brandon's embedding code in main.js back upstream?
[x] schema.js replaces data.js

ddooley commented 2 years ago

I think Brandon's embedding code is now obsolete re linkml-datastructure branch. Working on help dialog slot attribute display in separate thread. I'll spruce that up today according to those requests.

turbomam commented 2 years ago

Working on help dialog slot attribute display in separate thread

great!

Can you point me towards any notes about possible improvements to the help dialogs? I was just experimenting with the ways that DH acts on various LinkML slot attributes for either validation or help at https://github.com/microbiomedata/dh_testing

I have some relevant but verbose notes. One could could look for appearances of "help" in https://github.com/microbiomedata/dh_testing/issues/3#issue-1320224735

I could probably formalize that issue comments some if that would be helpful.

ddooley commented 2 years ago

I guess dh_testing is private. Can you get ddooley on there? Thx!

turbomam commented 2 years ago

I made it public

ddooley commented 2 years ago

Well, if you want to add stuff to a column help view of a column, then getCommentDict(slot) should be the dictionary to add textual key/values for, and then getComment provides the HTML available to the double click header. Admittedly that function is built into DataHarmoniser class. I guess it could be overwritten if you wanted a customized display?

renderReference() also uses the very same getCommentDict(slot) as getComment() for each of the slots.

Is that what you needed confirmation about?

ddooley commented 2 years ago

It would be good to formalize what you need, or just put in a pull request for more content in getCommentDict(slot) and getComment() if it is generically applicable for other DH users!