search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
91 stars 25 forks source link

Validation button in linkml datastructure branch broken #281

Closed turbomam closed 2 years ago

turbomam commented 2 years ago

Clicking the Validate button shows visual feedback, but there's no "Next Error" or "No Errors" message/buttons

ddooley commented 2 years ago

I've done a cursory test on some templates and fields and do get the "Next Error" button showing. Can you give me a dataset that it fails on? I suspect a particular field type is generating an error. Yesterday I had to add another commit to fix a .pattern validation issue BTW.

turbomam commented 2 years ago

Yeah, sorry, I left that out all my recent issues! I'll post the address for a LinkML file in a minute.

turbomam commented 2 years ago

Try this LinkML input: https://raw.githubusercontent.com/microbiomedata/sheets_and_friends/main/artifacts/nmdc_dh.yaml

You could just move it into template/nmdc_dh/source in the linkml-datastructure branch, overwriting the nmdc_dh.yaml that's already in there

Then make clean; make template/nmdc_dh/schema.js

You could load this data file: https://raw.githubusercontent.com/microbiomedata/sheets_and_friends/main/data/nmdc_test_data_valid.tsv