search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
91 stars 25 forks source link

Edge case: opening a DH template based on a class with no slots #283

Closed turbomam closed 2 years ago

turbomam commented 2 years ago

If the user selects a DH template with no slots, they get a DH interface with no columns. That's as expected.

However, if they select a template that does have slots after that, then it's columns don't appear

ddooley commented 2 years ago

Always good to give an example of specific DH template with no slots so I can replicate!

turbomam commented 2 years ago

Try this: https://raw.githubusercontent.com/microbiomedata/sheets_and_friends/main/artifacts/nmdc_dh.yaml

You could just move it into template/nmdc_dh/source in the linkml-datastructure branch, overwriting the nmdc_dh.yaml that's already in there

Then make clean; make template/nmdc_dh/schema.js

Templates like soil_emsl_jgi_mg are fine (although see #276 about the column and section layout)

However, open the quantity value and you will see no columns. That's OK, although it would be nice to have an exclusion list #282

Then go back to soil_emsl_jgi_mg. It's columns don't appear after viewing quantity value.

ddooley commented 2 years ago

This should be fixed now with latest commit. Reopen if I'm wrong!