search

cidgoh / DataHarmonizer

A standardized browser-based spreadsheet editor and validator that can be run offline and locally, and which includes templates for SARS-CoV-2 and Monkeypox sampling data. This project, created by the Centre for Infectious Disease Genomics and One Health (CIDGOH), at Simon Fraser University, is now an open-source collaboration with contributions from the National Microbiome Data Collaborative (NMDC), the LinkML development team, and others.
MIT License
94 stars 26 forks source link

Reference guide fixes #304

Closed pkalita-lbl closed 2 years ago

pkalita-lbl commented 2 years ago

The newly added renderReference method should be very useful in solving https://github.com/microbiomedata/sheets_and_friends/issues/119. However I noticed a bug where each time getCommentDict was called (either by opening the Reference Guide or double clicking a column header) the patten hint kept getting duplicated. These changes fix that issue by not modifying the slot's comments field, which was getting copied by reference and then appended to.

I also made some quick fixes to prevent global variables from leaking out of the renderReference method.

pkalita-lbl commented 2 years ago

cc @ddooley @turbomam

ddooley commented 2 years ago

Ok, thanks for that catch! Approved

turbomam commented 2 years ago

I know this has already been merged, but I just wanted to say how happy I am with it.